Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

feature: streaming support #82

Merged
merged 4 commits into from
Aug 4, 2023
Merged

feature: streaming support #82

merged 4 commits into from
Aug 4, 2023

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Jul 26, 2023

Reason for This PR

ref: roadrunner-server/roadrunner#923

Description of Changes

  • Update static pool to support streaming capabilities.
  • Remove stop worker handler. worker::stop would be deprecated as unused in RR 2023.3.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jul 26, 2023
@rustatian rustatian requested a review from wolfy-j July 26, 2023 08:35
@rustatian rustatian self-assigned this Jul 26, 2023
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian marked this pull request as ready for review August 4, 2023 13:49
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #82 (2ca42bd) into master (d72a218) will decrease coverage by 0.67%.
Report is 1 commits behind head on master.
The diff coverage is 67.81%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   83.09%   82.42%   -0.67%     
==========================================
  Files          22       22              
  Lines        1922     1952      +30     
==========================================
+ Hits         1597     1609      +12     
- Misses        270      292      +22     
+ Partials       55       51       -4     
Files Changed Coverage Δ
payload/payload.go 100.00% <ø> (ø)
state/process/state.go 85.00% <ø> (ø)
pool/static_pool/workers_pool.go 70.68% <56.25%> (ø)
worker/worker.go 83.47% <75.64%> (-1.26%) ⬇️
pool/static_pool/stream.go 84.61% <84.61%> (ø)
pool/allocator.go 87.50% <100.00%> (ø)
worker_watcher/worker_watcher.go 86.98% <100.00%> (-2.06%) ⬇️

... and 2 files with indirect coverage changes

@rustatian rustatian merged commit 21462d6 into master Aug 4, 2023
8 checks passed
@rustatian rustatian deleted the feature/streaming-support branch August 4, 2023 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Status: Unreleased
Development

Successfully merging this pull request may close these issues.

1 participant